Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APOGEE loaders #560

Merged
merged 2 commits into from
Dec 15, 2019
Merged

Fix APOGEE loaders #560

merged 2 commits into from
Dec 15, 2019

Conversation

adrn
Copy link
Member

@adrn adrn commented Dec 14, 2019

This fixes #559 by switching the kwargs from dispersion to spectral_axis in the APOGEE data loaders.

I also added very basic tests that at least download APOGEE data files and try the loaders on the data files.

Copy link
Contributor

@nmearl nmearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @adrn.

@nmearl nmearl merged commit f687076 into astropy:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apogee loaders broken with DR16 spectra
2 participants