-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set :noindex: #150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 89.31% 89.90% +0.59%
==========================================
Files 24 27 +3
Lines 1104 1139 +35
==========================================
+ Hits 986 1024 +38
+ Misses 118 115 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Wasn't easy but I managed to add a test :) |
This comment was marked as resolved.
This comment was marked as resolved.
31365f9
to
3fed892
Compare
All green now :) |
Ooooo... how do we use this in |
No magic :D, we must add |
@saimn , is there an |
@pllim - no, I could do that indeed 👍 |
@saimn , any chance we can push this forward? Did you say there is something that not quite working still using this with @WilliamJamieson is unable to build |
Within another round of testing/debugging on Astropy I'm pretty convinced that the changes here are correct and are doing what is supposed. Adding |
Is it time to make astropy less complicated?! We cannot pin Sphinx forever. |
I have been working on this for years 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,11 @@ | |||
project = 'duplicated' | |||
copyright = '2022, Maximilian Nöthe' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LoL does @maxnoe consent to be immortalized as a test case like this? 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I am Maximilian Linhoff now ;)
sphinx_automodapi/tests/duplicated_warning/duplicated/foo/foo.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks. If you want to address them, great. If not, we can defer. Though that one typo should probably be fixed anyway before merge.
Let's ship this indeed and then fix up astropy! 🚀
Even though astropy core doesn't need this, we might as well merge it? |
This comment was marked as resolved.
This comment was marked as resolved.
Gah, CI got disabled. I have to close/reopen. |
Merged! I'll let someone else do the release. Thanks, all! |
Fix #130.
TODO: see if I can add a test for this.