Deactivate chunked body in S3 #911
Conversation
jderusse
force-pushed
the
chunk-body
branch
2 times, most recently
from
b9b44cb
to
5caa3ad
Compare
| if ($contentLength < self::CHUNK_SIZE || !$this->sendChunkedBody) { | ||
| if ($body instanceof ReadOnceResultStream) { | ||
| $request->setBody(RewindableStream::create($body)); | ||
| } |
There was a problem hiding this comment.
What if the body is not an instance of ReadOnceResultStream?
There was a problem hiding this comment.
$body is initialized from $body = $request->getBody().
If it's not an instance of ReadOnceResultStream, then we are good, we can rewind the stream.
There was a problem hiding this comment.
I fail to understand why though.. Before, we always converted to a StringStream if the body was small, but now we dont anymore. Was it a misstake before?
There was a problem hiding this comment.
Yes, I believe the conversation were not needed.
If I remember well, when I implemented the conversion to string, the ReadOnceResultStream did not exists and stream have to be converted into string at some point.
Now, thanks to the RewindableStream, the signature is able to works with all cases, but I forgot to revert upgrade this statement.
| if ($contentLength < self::CHUNK_SIZE || !$this->sendChunkedBody) { | ||
| if ($body instanceof ReadOnceResultStream) { | ||
| $request->setBody(RewindableStream::create($body)); | ||
| } |
There was a problem hiding this comment.
I fail to understand why though.. Before, we always converted to a StringStream if the body was small, but now we dont anymore. Was it a misstake before?
|
last test fails because of doctrine/annotations#398 |
|
Thank you for the review |
|
Awesome. Thank you! |
Fixes #874