-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal context missing when there's no connection_init
frame
#451
Comments
I checked the protocol specification of What do you think? |
Agreed. If |
Now, if the client sends Released in |
Awesome, thanks @sunli829 ! 🚀 |
After working on vectordotdev/vector#6871, I discovered an error in our Vector API client where a
start
operation was sent before aconnection_init
message.A side-effect to this is that context provided in
graphql_subscription_with_data()
isn't added, because there's no initial payload to merge with. This resulted in panics when usingContext.data_unchecked
.It would be useful for 'internal' context to be injected without relying on a connection_init message from the client so this doesn't need to be a checked operation.
If it is provided, then this would be merged with the initial payload as normal.
Does that seem reasonable? Or would you recommend simply using checked operations at all times?
The text was updated successfully, but these errors were encountered: