Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lru to 0.7.1 #773

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

QuentinPerez
Copy link
Contributor

@QuentinPerez QuentinPerez commented Dec 30, 2021

👋 A small PR to bump lru due to a RUSTSEC.

async-graphql is not impacted but cargo-audit complains about the fact that we should update dependency which depends on it


Use after free in lru crate
= ID: RUSTSEC-2021-0130
= Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0130
= Lru crate has use after free vulnerability.

  Lru crate has two functions for getting an iterator. Both iterators give
  references to key and value. Calling specific functions, like pop(), will remove
  and free the value, and but it's still possible to access the reference of value
  which is already dropped causing use after free.
= Announcement: jeromefroe/lru-rs#120
= Solution: Upgrade to >=0.7.1

The advisory script brought up a RUSTSEC error:

---
error[A001]: Use after free in lru crate
    ┌─ /home/haptop/Developer/radicle-link/Cargo.lock:207:1
    │
207 │ lru 0.6.6 registry+https://github.com/rust-lang/crates.io-index
    │ --------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2021-0130
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2021-0130
    = Lru crate has use after free vulnerability.

      Lru crate has two functions for getting an iterator. Both iterators give
      references to key and value. Calling specific functions, like pop(), will remove
      and free the value, and but it's still possible to access the reference of value
      which is already dropped causing use after free.
    = Announcement: jeromefroe/lru-rs#120
    = Solution: Upgrade to >=0.7.1
---

This patch follows the recommended solution and pins the `lru` crate
to 0.7.1.
@sunli829
Copy link
Collaborator

sunli829 commented Jan 5, 2022

Thanks!

@sunli829 sunli829 merged commit a70db3c into async-graphql:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants