Use a simple get/set accessor instead #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Jan 31, 2017
|
|
||
| /** | ||
| * Accessor to allow global access to the event loop. | ||
| * Accessor to allow global access to the event loop |
kelunik
reviewed
Jan 31, 2017
src/Loop.php
Outdated
|
|
||
| /** | ||
| * Retrieve the event loop driver that is in scope. | ||
| * Retrieve the current event loop driver | ||
| * | ||
| * @return Driver |
There was a problem hiding this comment.
Must be @return Driver|null then.
Open
|
@WyriHaximus There seems to be general approval to this PR… So, looking forward to the feedback from @clue and @cboden, then I'll merge this if we can agree on everything (also Driver). |
|
I have a busy week at work. I'll take a look as soon as I can which probably won't be until the weekend. |
|
A quick reminder @cboden :-) |
|
Closing, as project discontinued for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we ended up disagreeing on a common global accessor, I propose simplifying the whole accessor to just a get()+set() method pair.
This ensures that the loop will be interoperable at all (otherwise we'd end up having different loops active or worse things).
Now, every library can choose its own accessors as desired.
This should resolve the current point of contention.
Is this something we all can agree on?
\cc @kelunik @trowski @clue @WyriHaximus @martinschroeder @jsor @cboden @davidwdan @mbonneau @rdlowrey (please leave a thumbs up or down)
After that, I guess we can relatively quickly go to tagging v1 then as I haven't seen much objection on the Driver interface itself at all.