Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when the main folder contains flame.html or tree.html files #743

Merged

Conversation

parttimenerd
Copy link
Contributor

Tiny fix for the case that the current async-profiler folder contains flame.html or tree.html or files. The build script currently takes these files instead of the files from src/res, causing an error during the flame graph generation. This is problematic because flame.html is not an uncommon name for created flame graph files.

@apangin
Copy link
Collaborator

apangin commented Apr 20, 2023

Oops, you apparently committed extra files

@parttimenerd
Copy link
Contributor Author

Oh, thanks for spotting this, I updated the commit.

@apangin apangin merged commit f57d3dc into async-profiler:master Apr 20, 2023
1 check passed
@apangin
Copy link
Collaborator

apangin commented Apr 20, 2023

Looks good now. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants