Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter: add warning when running with -jar instead of -cp #827

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

selckin
Copy link
Contributor

@selckin selckin commented Oct 19, 2023

Prevents users like me wasting time

@apangin
Copy link
Collaborator

apangin commented Oct 19, 2023

Accepting both -cp and -jar would result in even better user experience.
Instead of printing a suggestion, converter can do the trick automatically.

@selckin selckin force-pushed the patch-1 branch 3 times, most recently from ac2547b to 03d900a Compare November 24, 2023 13:30
@selckin
Copy link
Contributor Author

selckin commented Nov 24, 2023

Accepting both -cp and -jar would result in even better user experience. Instead of printing a suggestion, converter can do the trick automatically.

Updated

@apangin apangin merged commit 48a97b6 into async-profiler:master Nov 24, 2023
1 check passed
@apangin
Copy link
Collaborator

apangin commented Nov 24, 2023

I've merged PR with minor changes. Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants