New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#873: the accuracy issue of ObjectSampler in --total mode #876

Merged

apangin merged 1 commit into async-profiler:master from yanglong1010:fix-object-sampler

Jan 5, 2024

Contributor

yanglong1010 commented Jan 5, 2024

Hi Andrei

As discussed in #873.

Because JEP 331 doesn't return the actual pseudo-random interval in JVM, the event._total_size is the best we can use now.

I would appreciate it if you can help review this.


          async-profiler#873: the accuracy issue of ObjectSampler in --total mode

3e64b39

apangin merged commit 8910a7a into async-profiler:master

1 check passed

Collaborator

apangin commented Jan 5, 2024

Merged. Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment