fix(jfr2pprof): Fix multichunk jfr symbols and location's line numbers #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not use one.jfr.JfrReader#readAllEvents(java.lang.Class<E>) as it may trigger reading new chunk in multichunk jfrs, overwriting cp, producing wrong data(I observerd wrong class names) - Use Location(method+line) as dedup key to fix line numbers
apangin
reviewed
Jan 16, 2024
src/converter/jfr2pprof.java
Outdated
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(method, line); |
There was a problem hiding this comment.
Objects.hash is inefficient because of varargs - please rewrite the method without Objects.hash. As a general rule, hashCode should not allocate.
There was a problem hiding this comment.
Thanks. Rewritten.
|
Merged. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use one.jfr.JfrReader#readAllEvents(java.lang.Class) as it may trigger reading new chunk in multichunk jfrs, overwriting cp, producing wrong data(I observerd wrong class names). Note: it is still used in netflix code I did not touch.
Use Location(method+line) as dedup key to fix line numbers
I've used this JFR file for testing, captured by Intellij IDEA Ultimate on Linux
FastSlow_2024_01_16_180855.jfr.zip