Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary trait bound on FlatMap #651

Merged
3 commits merged into from
Jan 13, 2020
Merged

Remove unnecessary trait bound on FlatMap #651

3 commits merged into from
Jan 13, 2020

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Dec 29, 2019

ref: #649

@kiljacken
Copy link

Any updates here?

taiki-e
taiki-e approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- but it would be nice to have a test to ensure that #649 can be compiled (to avoid regression in the future).

yoshuawuyts
yoshuawuyts approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though agree with @taiki-e that adding a test for #649 would be great.

@k-nasa
Copy link
Member Author

k-nasa commented Jan 13, 2020

I fixed test.

ghost
ghost approved these changes Jan 13, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 0ed0d63 into async-rs:master Jan 13, 2020
@k-nasa k-nasa deleted the remove_unnecessary_trait_bound_on_flat_map branch January 13, 2020 22:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k-nasa @kiljacken @yoshuawuyts @taiki-e