Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update to new parser api #746

Merged
merged 10 commits into from
Aug 30, 2023
Merged

feat!: update to new parser api #746

merged 10 commits into from
Aug 30, 2023

Conversation

jonaslagoni
Copy link
Sponsor Member

Description
This PR updates the library to the newest parser API, and effectively adds support for v3 (at least it can understand v3).

github-actions[bot]
github-actions bot reviewed Aug 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@fmvilas fmvilas mentioned this pull request Aug 25, 2023
Closed
5 tasks
@jonaslagoni
Copy link
Sponsor Member Author

FYI, I had to update to webpack 5 to make it work, but don't see that as a downside 😆

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Sponsor Member Author

@fmvilas @derberg @magicmatatjahu all tests finally pass and it builds correctly, please have a look when you can 🙏

@jonaslagoni jonaslagoni mentioned this pull request Aug 29, 2023
Closed
fmvilas
fmvilas approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Sponsor Member Author

@fmvilas I am leaving merging to you folks.

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

Are you afraid of something? 😄

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

/rtm

@fmvilas
Copy link
Member

fmvilas commented Aug 30, 2023

/rtm

@fmvilas fmvilas merged commit eabba4f into asyncapi:next Aug 30, 2023
9 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.49 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the update_parser_api branch August 30, 2023 17:20
@jonaslagoni jonaslagoni mentioned this pull request Sep 1, 2023
Merged
@derberg derberg mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@fmvilas fmvilas fmvilas approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonaslagoni @fmvilas @asyncapi-bot @magicmatatjahu