Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for avro 1.8.2 #6

Merged
merged 5 commits into from
Aug 24, 2020

Conversation

germanschnyder
Copy link
Contributor

@germanschnyder germanschnyder commented Aug 20, 2020

Description

  • Added avro 1.8.2 as supported mimetype
  • Refactored examples to show that both 1.8.2 and 1.9.0 are correctly parsed. Added enum default value and uuid entry to previous 1.9.0 example. Also renamed the files.
  • Bumped up minor version

The only difference between schemas is that 1.9.0 supports enum default and adds uuid as a new type. These both were considered when testing the parser.

Resolves #7

@germanschnyder germanschnyder changed the title Adding support for avro 1.8.2 feat: adding support for avro 1.8.2 Aug 21, 2020
package.json Outdated Show resolved Hide resolved
@derberg derberg requested a review from fmvilas August 21, 2020 08:01
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @germanschnyder!

@@ -18,6 +18,7 @@ const typeMappings = {
array: 'array',
enum: 'string',
record: 'object',
uuid: 'string',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏

@fmvilas fmvilas merged commit 6447ab8 into asyncapi:master Aug 24, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support avro spec 1.8.2
4 participants