Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP message headers vs Message object headers #158

Closed
jonaslagoni opened this issue Oct 12, 2022 · 9 comments
Closed

HTTP message headers vs Message object headers #158

jonaslagoni opened this issue Oct 12, 2022 · 9 comments
Labels
bug Something isn't working stale

Comments

@jonaslagoni
Copy link
Member

Given that the native message object allows you to define headers, what's the reason behind having the HTTP message bindings define their own property for defining headers?

@jonaslagoni jonaslagoni added the bug Something isn't working label Oct 12, 2022
@derberg
Copy link
Member

derberg commented Oct 18, 2022

this is a good question 🤔
@fmvilas I can't figure that out from commit history

@fmvilas
Copy link
Member

fmvilas commented Oct 20, 2022

Yeah, I think this is just because I completely forgot about it when creating the HTTP binding. We should definitely remove it in favor of message headers IMHO.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 18, 2023
@jonaslagoni
Copy link
Member Author

Same with WebSocket 🤔

@github-actions github-actions bot removed the stale label Mar 24, 2023
@fmvilas
Copy link
Member

fmvilas commented May 30, 2023

I now remember why. Message headers are application-specific headers and the binding headers are protocol-specific headers. It's just a separation of concerns. This way, for instance, you can have the same message for two different protocols but still be able to provide specific headers for HTTP and for others.

@jonaslagoni
Copy link
Member Author

jonaslagoni commented May 30, 2023

Ahhh, that makes sense!

Wonder if we should include this piece of information in the bindings? 🤔

@fmvilas
Copy link
Member

fmvilas commented May 31, 2023

Yeah, wouldn't hurt to remind it there. We saw it can be easily forgotten 😄

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 29, 2023
@jonaslagoni
Copy link
Member Author

Reason for the difference can be read here: #158 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

3 participants