Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for diff markdown output #295

Merged
merged 21 commits into from Jun 28, 2023
Merged

feat: add support for diff markdown output #295

merged 21 commits into from Jun 28, 2023

Conversation

aayushmau5
Copy link
Member

@aayushmau5 aayushmau5 commented Jun 21, 2022 •
edited

Description

  • This PR adds support for Markdown output by diff that has been added recently in the diff library.
  • Currently, the markdown output is printed to stdout

@aayushmau5
Copy link
Member Author

aayushmau5 commented Jun 21, 2022 •
edited

Created a draft PR for now. Have to make the tests better, and refactor some things. Done :D

@aayushmau5 aayushmau5 marked this pull request as ready for review July 5, 2022 18:08
Souvikns
Souvikns requested changes Jul 6, 2022
View reviewed changes
src/commands/diff.ts Outdated Show resolved Hide resolved
@aayushmau5 aayushmau5 requested a review from Souvikns July 6, 2022 16:56
Souvikns
Souvikns previously approved these changes Jul 7, 2022
View reviewed changes
boyney123
boyney123 reviewed Jul 7, 2022
View reviewed changes
src/commands/diff.ts Outdated Show resolved Hide resolved
Souvikns
Souvikns previously approved these changes Jul 11, 2022
View reviewed changes
magicmatatjahu
magicmatatjahu suggested changes Jul 11, 2022
View reviewed changes
src/commands/diff.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushmau5 🙏🏼

src/commands/diff.ts Outdated Show resolved Hide resolved
src/commands/diff.ts Outdated Show resolved Hide resolved
src/commands/diff.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg reviewed Feb 8, 2023
View reviewed changes
src/commands/diff.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Mar 27, 2023

@aayushmau5 some tests related to diff are failing, don't think it is random stuff

@aayushmau5
Copy link
Member Author

@derberg will check and fix! Thanks for the heads up.

@derberg
Copy link
Member

derberg commented Apr 24, 2023

@aayushmau5 yo, I suggest resolving conflicts and updating to latest master as lots of random issues in flaky tests were fixed, and all should be good here after update

@aayushmau5
Copy link
Member Author

@derberg will do. Was fixing the tests, but some tests were timing out locally. Hopefully the latest master will have this fix.

@Souvikns
Copy link
Member

@aayushmau5 can you let me know if you are facing the same issues with the tests now?

@aayushmau5
Copy link
Member Author

aayushmau5 commented Jun 17, 2023 •
edited

@Souvikns fixed all the tests. No sure what to do with sonar. As you can see, I spent the last 2 hours fighting with it xD

I think the duplication is necessary. Either we can ignore it somehow or try to find better way to store test outputs.

derberg
derberg reviewed Jun 27, 2023
View reviewed changes
sonar-project.properties Outdated Show resolved Hide resolved
derberg
derberg reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to rename sonar config file to .sonarcloud.properties, the other is somehow ignored now

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg requested a review from Souvikns June 27, 2023 13:36
derberg
derberg approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Souvikns please have a look

@derberg Volta.net
Copy link
Member

derberg commented Jun 27, 2023

/rtm

@derberg
Copy link
Member

derberg commented Jun 28, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 1d95543 into asyncapi:master Jun 28, 2023
13 checks passed
@aayushmau5 aayushmau5 deleted the diff-markdown-output branch June 28, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@Souvikns Souvikns Souvikns approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@boyney123 boyney123 Awaiting requested review from boyney123

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aayushmau5 @derberg @Souvikns @boyney123 @magicmatatjahu @asyncapi-bot