Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instruction how voting automation works #1155

Merged
merged 31 commits into from
Apr 25, 2024

Conversation

AayushSaini101
Copy link
Contributor

@AayushSaini101 AayushSaini101 commented Apr 9, 2024

Related to #1093

Message from @derberg

We just enabled automation around voting process (using same tool as CNCF). We already enabled it but only to be able to test it now, in this PR as a first automated decision. We can always disable it if we do not reach consensus.

This PR contains documentation on how voting process works. Please have a look and vote or leave a comment if something is not clear or you do not agree with.

There are some changes, like for example no more voting through discussions (technical limitation that imho is not that bad after all)

voting instruction and comment where to leave a vote: #1155 (comment)

@AayushSaini101 AayushSaini101 changed the title doc: added voting.md file docs: added voting.md file Apr 9, 2024
@asyncapi asyncapi deleted a comment from github-actions bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from AayushSaini101 Apr 9, 2024
@asyncapi asyncapi deleted a comment from github-actions bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from git-vote bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from AayushSaini101 Apr 9, 2024
@derberg derberg changed the title docs: added voting.md file docs: add instruction how voting automation works Apr 9, 2024
@asyncapi asyncapi deleted a comment from github-actions bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from AayushSaini101 Apr 9, 2024
@asyncapi asyncapi deleted a comment from github-actions bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from git-vote bot Apr 9, 2024
@asyncapi asyncapi deleted a comment from AayushSaini101 Apr 9, 2024
@AayushSaini101
Copy link
Contributor Author

/vote

Copy link

git-vote bot commented Apr 9, 2024

Only repository collaborators can create a vote @AayushSaini101.

For organization-owned repositories, the list of collaborators includes outside collaborators, organization members that are direct collaborators, organization members with access through team memberships, organization members with access through default organization permissions, and organization owners.

@asyncapi-bot-eve
Copy link
Contributor

Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process

@AayushSaini101
Copy link
Contributor Author

/cancel-vote

@asyncapi-bot-eve
Copy link
Contributor

Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process

@derberg
Copy link
Member

derberg commented Apr 9, 2024

/vote

Copy link

git-vote bot commented Apr 9, 2024

Vote created

@derberg has called for a vote on docs: add instruction how voting automation works (#1155).

The members of the following teams have binding votes:

Team
@asyncapi/tsc_members

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 28days. It will pass if at least 51% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@asyncapi-bot-eve asyncapi-bot-eve added the vote used for TSC voting label Apr 9, 2024
@derberg
Copy link
Member

derberg commented Apr 9, 2024

@asyncapi/tsc_members please look at description of this PR and then voting instructions #1155 (comment)

This is a first voting with automation:

Please look on voting.md and if you agree or disagree - vote as per instructions or just ask a comment to clarify instructions

@derberg
Copy link
Member

derberg commented Apr 16, 2024

@alequetzalli since your last review there were some sections added, can you please have a look?

@AayushSaini101
Copy link
Contributor Author

@alequetzalli since your last review there were some sections added, can you please have a look?

@derberg please review :)

derberg
derberg previously approved these changes Apr 18, 2024
thulieblack
thulieblack previously approved these changes Apr 18, 2024
@whitlockjc
Copy link
Contributor

👍

@asyncapi-bot
Copy link
Contributor

Hello, @AayushSaini101! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: To request an update from the upstream branch, simply comment /u or /update and our bot will handle the update operation promptly.

       The only requirement for this to work is to enable [Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) option in your PR. Also the update will not work if your fork is located in an organization, not under your personal profile.
       Thanks 😄

@AayushSaini101
Copy link
Contributor Author

@alequetzalli is not active due to some reasons from the last couple of days, also her suggestions resolved in this commit thanks @thulieblack, I also improved a lot and other improvements can be done later if any case find in the doc. :) thanks

voting.md Outdated Show resolved Hide resolved
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
@smoya
Copy link
Member

smoya commented Apr 19, 2024

@alequetzalli is not active due to some reasons from the last couple of days, also her suggestions resolved in this commit thanks @thulieblack, I also improved a lot and other improvements can be done later if any case find in the doc. :) thanks

Merging is blocked due to @alequetzalli requests.
Google Chrome_5mClnR9E

Unless another owner dismisses it's review, I believe you won't be able to get this PR merged before Alejandra comes back.
My personal opinion: I believe we are not in such a rush and you should wait for Alejandra's approval. But I'm not owner so 🤷

@derberg
Copy link
Member

derberg commented Apr 23, 2024

@alequetzalli should we wait for you?

@derberg
Copy link
Member

derberg commented Apr 25, 2024

ok, I checked and changes requested by @alequetzalli were addressed. They also do not relate to the core of the PR, so if some text can be done better, and more clear later, there can always be a followup PR.

@AayushSaini101 thanks a lot for the work! There were over 30 votes provided 🚀

@derberg derberg merged commit 64a043a into asyncapi:master Apr 25, 2024
7 checks passed
@git-vote git-vote bot added the gitvote label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty gitvote vote used for TSC voting
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

None yet