Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial v3 converter support #180

Merged
merged 28 commits into from
Jul 24, 2023
Merged

feat: add initial v3 converter support #180

merged 28 commits into from
Jul 24, 2023

Conversation

jonaslagoni
Copy link
Sponsor Member

@jonaslagoni jonaslagoni commented Jun 13, 2023 •
edited by fmvilas

Description
This PR is an extension to what @magicmatatjahu did in #163

TODO:

TODO after merge:

  • Add parameter conversion

Related issue(s)
Part of #110
Fixes #188

@jonaslagoni jonaslagoni changed the title Add v3 support feat: add v3 converter support Jun 13, 2023
@jonaslagoni
Copy link
Sponsor Member Author

I cant figure out whether we need to add a warning if traits + target object contains the same property (i.e. the breaking behavior of asyncapi/spec#907).

@jonaslagoni
Copy link
Sponsor Member Author

Should we do binding conversion as well? 🤔

@jonaslagoni jonaslagoni changed the title feat: add v3 converter support feat: add initial v3 converter support Jun 22, 2023
@jonaslagoni
Copy link
Sponsor Member Author

Still missing adding change for: asyncapi/spec#935

@jonaslagoni jonaslagoni marked this pull request as ready for review June 22, 2023 11:20
@jonaslagoni
Copy link
Sponsor Member Author

Even though this PR is not the final PR for v3 conversion, I will say this is a good enough state that we can release it as it is right now. - And directly to master, I don't see why not, although it's an experimental feature 😄

You do have to explicitly define that you want to convert to v3.

@jonaslagoni jonaslagoni requested a review from fmvilas June 26, 2023 19:38
fmvilas
fmvilas previously approved these changes Jun 27, 2023
View reviewed changes
@derberg
Copy link
Member

derberg commented Jun 27, 2023

code smells 😄

@jonaslagoni
Copy link
Sponsor Member Author

I refactored everything that seemed problematic, and nothing extra has been added 🙂

Need a final review @derberg @fmvilas @magicmatatjahu

@jonaslagoni jonaslagoni requested a review from fmvilas June 27, 2023 16:21
@jonaslagoni
Copy link
Sponsor Member Author

Anytime now @fmvilas @derberg @magicmatatjahu 😆

derberg
derberg approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see it coming ❤️ . All good from my side but let's have approval from folks that also did a code review initially

@derberg
Copy link
Member

derberg commented Jul 6, 2023

@magicmatatjahu any time? or busy "working" from Georgia? 😛

fmvilas
fmvilas approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

magicmatatjahu
magicmatatjahu approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Jul 20, 2023
Closed
Closed
@jonaslagoni
Copy link
Sponsor Member Author

/rtm

@jonaslagoni
Copy link
Sponsor Member Author

Thanks folks 🥳

@asyncapi-bot asyncapi-bot merged commit 211fc48 into asyncapi:master Jul 24, 2023
14 checks passed
@jonaslagoni jonaslagoni deleted the add_v3_support branch July 24, 2023 08:28
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert 2.X.X to 3.0.0
5 participants
@jonaslagoni @derberg @asyncapi-bot @fmvilas @magicmatatjahu