Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add next-major branch to release list #755

Merged
merged 12 commits into from
Apr 8, 2022
Merged

chore: add next-major branch to release list #755

merged 12 commits into from
Apr 8, 2022

Conversation

jonaslagoni
Copy link
Sponsor Member

Description
This PR adds the next-major branch to the release list.

Related issue(s)
Related to spec 3.0 asyncapi/spec#691

@jonaslagoni jonaslagoni requested a review from derberg March 2, 2022 17:52
@jonaslagoni jonaslagoni mentioned this pull request Mar 2, 2022
Closed
@jonaslagoni
Copy link
Sponsor Member Author

We also need to add branch protection to next-major.

@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

derberg
derberg previously approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created branch protection for you for the new release branch

@derberg
Copy link
Member

derberg commented Mar 8, 2022

@jonaslagoni It would make sense to open up a PR from next-major to master with don-not-merge label. This way bot will make sure to always update release branch with latest master....if possible of course. Anyway release branch requires an update as there are some missing workflows that will not work with branch protection

@jonaslagoni
Copy link
Sponsor Member Author

This is still relevant based on asyncapi/spec#734 (comment)

@jonaslagoni
Copy link
Sponsor Member Author

@jonaslagoni It would make sense to open up a PR from next-major to master with don-not-merge label. This way bot will make sure to always update release branch with latest master....if possible of course. Anyway release branch requires an update as there are some missing workflows that will not work with branch protection

Yes, will do that 👍

@derberg derberg closed this Apr 5, 2022
@derberg derberg reopened this Apr 5, 2022
@derberg
Copy link
Member

derberg commented Apr 5, 2022

closed/reopened as some jobs were "hanging"
@jonaslagoni once it is green merge when you need it

@jonaslagoni
Copy link
Sponsor Member Author

@derberg had to update with master for checks to go through 😅

@jonaslagoni jonaslagoni requested a review from derberg April 6, 2022 10:03
@jonaslagoni jonaslagoni closed this Apr 8, 2022
@jonaslagoni jonaslagoni reopened this Apr 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni merged commit d06cbe2 into asyncapi:next-major Apr 8, 2022
@jonaslagoni jonaslagoni deleted the feature/add_next_major branch April 8, 2022 11:16
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonaslagoni @derberg @asyncapi-bot @SP-SuperPoney @mcturco @magicmatatjahu