Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter description does not render in resulting output with html template #26

Closed
derberg opened this issue May 13, 2020 · 6 comments · Fixed by #109
Closed

Parameter description does not render in resulting output with html template #26

derberg opened this issue May 13, 2020 · 6 comments · Fixed by #109
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released

Comments

@derberg
Copy link
Member

derberg commented May 13, 2020

@maxs commented on Thu Mar 12 2020

In the folowing example description field won't be rendered in resulting output because it is not taken from the parameter toy but the schema. This means, to have description rendered, we would have to put description under schema block which is not intended behavior.

components:
  parameters:
    toy:
      description: Description of the toy
      schema:
        type: string

@github-actions[bot] commented on Thu Mar 12 2020

Welcome to AsyncAPI. Thanks a lot for reporting your first issue.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.


@derberg commented on Thu Mar 12 2020

Some additional hint:
When I quickly look into the code of HTML template, the schemaProp macro https://github.com/asyncapi/generator/blob/master/templates/html/.partials/operation.html#L45 gets only the schema object. So the description that is used in the template https://github.com/asyncapi/generator/blob/master/templates/html/.partials/schema-prop.html#L76 is not taken from the parameter but the schema.


@github-actions[bot] commented on Wed May 13 2020

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jul 13, 2020
@derberg derberg removed the stale label Jul 13, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Sep 12, 2020
@derberg derberg removed the stale label Sep 14, 2020
@derberg
Copy link
Member Author

derberg commented Sep 22, 2020

The logic that handles the rendering of information about Parameter is here and as you can see, it takes schema of the parameters and therefore displays only the description provided in the parameter. Maybe this macro needs to be extended?

@derberg derberg added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Oct 1, 2020
@derberg
Copy link
Member Author

derberg commented Oct 1, 2020

video about the issue https://youtu.be/Iqs_2BiNEEo?t=677

@derberg
Copy link
Member Author

derberg commented Oct 22, 2020

@maxs this is fixed and released

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants