feat!: adds extend in common, meta, and constrained models #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethaasan
requested review from
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modelina canceled.
|
jonaslagoni
requested changes
Nov 16, 2023
jonaslagoni
requested changes
Nov 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jonaslagoni, thanks! I added a section in the migration guidelines now. I was trying to make it as general as possible, and will add more specifics for Java in the next PR. |
jonaslagoni
approved these changes
Nov 18, 2023
| } | ||
| }); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Yea, if we show in the subsequent PRs how that code will look in the different generators, that would be nice 👌
|
🎉 This PR is included in version 3.0.0-next.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonaslagoni
added a commit
that referenced
this pull request
Feb 1, 2024
* feat!: convert to use multi parser (#1587) * feat!: adds support for duration in java (#1604) * feat: enable AsyncAPI v3 (#1600) * fix!: add csharp support for DateTime, TimeSpan, Guid (#1612) * feat!: adds extend in common, meta, and constrained models (#1613) * feat!: adds inheritance with interfaces for java (#1593) * chore: remove duplicate version entry for AsyncAPI processor (#1609) * feat!: render python union in pydantic in the pre 3.10 way (#1626) * feat: add file path as input (#1601) * feat!: add options as parameter to constraints (#1667) * fix: (un)marshalling tuple and dictionary unwrapping for Typescript (#1717) * fix: jsonbinpack preset and runtime tests (#1718) * chore: fix linting * chore: remove unused directory * feat!: add useJavascriptReservedKeywords option for TS (#1727) * feat: enable raw properties for interface (#1729) * fix: newtonsoft could not handle enum values (#1731) * chore: update Java runtime tests (#1739) * fix: edge case where references was incorrect handled for JSON Schema (#1754) * fix: recursion bug for get nearest dependencies (#1757) --------- Co-authored-by: Kenneth Aasan <k.aasan@sportradar.com> Co-authored-by: jano-petras <jano.petras@gmail.com> Co-authored-by: Nilkanth Parmar <parmarnilkanth@gmail.com>
|
🎉 This PR is included in version 4.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation for adding inheritance with interfaces for Java in #1593
This PR finalizes what has been started regarding the
allowInheritanceoption, and addsextendin the CommonModel, MetaModel, and ConstrainedMetaModel. It also adds logic in the Splitter to split our extended models and setisExtendedin the options where this is needed.Related issue(s)
See also #108.