Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added kotlin constraint docs #1712

Merged

Conversation

officialasishkumar
Copy link
Contributor

Description

Related Issue

#1672

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 11ee32a
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6591d7a36787b000081ce2a8

@coveralls
Copy link

coveralls commented Dec 30, 2023

Pull Request Test Coverage Report for Build 7372721977

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.33%

Totals Coverage Status
Change from base Build 7372709417: 0.0%
Covered Lines: 5867
Relevant Lines: 6193

💛 - Coveralls

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the #1710 @officialasishkumar, can you double check the implementation and the docs match each other 🙂 Checkout the constraint logic here: https://github.com/asyncapi/modelina/blob/master/src/generators/kotlin/constrainer

@jonaslagoni jonaslagoni changed the title feat: added kotlin constraint docs docs: added kotlin constraint docs Dec 31, 2023
Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @officialasishkumar 🔥

@jonaslagoni jonaslagoni merged commit ccd02aa into asyncapi:master Dec 31, 2023
15 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants