-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add support functions for CommonModel #183
refactor: add support functions for CommonModel #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments :) Great job! Also, please change chore:
to refactor:
:)
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Please retry analysis of this Pull-Request directly on SonarCloud. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks 🎉 |
🎉 This PR is included in version 0.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR introduces some more functions to
CommonModel
, which are going to be used as part of the further refactoring of the simplifier.Furthermore, I added functionality to ensure that recursive
CommonModel
s are handles correctly when merging. With the current simplifier, this is not a problem so it is not afix:
.