Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: json tag support for go union #2048

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat: json tag support for go union #2048

merged 2 commits into from
Jun 20, 2024

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Jun 17, 2024 •
edited by jonaslagoni
Loading

Description

Adding json tags on go union types, to omit if empty.

Related Issue

Fixes #2034

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 038b380
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/66701bcad9ed3200088d8d83

@Souvikns Souvikns mentioned this pull request Jun 18, 2024
Open
@jonaslagoni jonaslagoni merged commit d6a0bdf into asyncapi:next Jun 20, 2024
19 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0-next.50 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Souvikns @asyncapi-bot @jonaslagoni