Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve generators and presets #60

Merged
merged 8 commits into from
Feb 15, 2021
Merged

chore: improve generators and presets #60

merged 8 commits into from
Feb 15, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Feb 15, 2021 •
edited

Description

Improve generators and presets:

  • render optional properties in TS class and interface,
  • improve typings in AbstractRenderer and AbstractGenerator,
  • add additionalContent preset to class, interface, enum renderers,
  • improve defaultSelf method in renderers,
  • move helpers method from Java enum to default preset.

Related issue(s)
See also #50

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Feb 15, 2021
@magicmatatjahu magicmatatjahu changed the title chore: improve typings in generators and presets chore: improve generators and presets Feb 15, 2021
@magicmatatjahu magicmatatjahu marked this pull request as ready for review February 15, 2021 12:57
@magicmatatjahu magicmatatjahu mentioned this pull request Feb 15, 2021
Closed
2 tasks
jonaslagoni
jonaslagoni previously approved these changes Feb 15, 2021
View reviewed changes
Copy link
Sponsor Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you got a few lint warnings though 😄

@magicmatatjahu
Copy link
Member Author

@jonaslagoni Thanks for review! Could you accept again? I fixed linter warnings related only to changed files in PR.

@magicmatatjahu magicmatatjahu mentioned this pull request Feb 15, 2021
Closed
@magicmatatjahu magicmatatjahu merged commit e3c2f62 into asyncapi:master Feb 15, 2021
@magicmatatjahu magicmatatjahu deleted the customisation-v2 branch February 15, 2021 13:50
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magicmatatjahu @asyncapi-bot @jonaslagoni