Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI spec v3 support in Node.js template #215

Closed
1 task
Tracked by #294 ...
jonaslagoni opened this issue Jun 5, 2023 · 8 comments
Closed
1 task
Tracked by #294 ...

AsyncAPI spec v3 support in Node.js template #215

jonaslagoni opened this issue Jun 5, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@jonaslagoni
Copy link
Sponsor Member

Reason/Context

This Issue is used to track changes needed to support AsyncAPI v3. As a code owner, please edit this list of TODO tasks in order to properly track the progress 🙂 Once this issue is closed it means that v3 is now fully supported in this library.

Remaining tasks:

@jonaslagoni jonaslagoni added the enhancement New feature or request label Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lukas-mertens
Copy link

@derberg Any progress on this? I would like to start using AsyncAPI and it feels like it would be best to start with the new spec version right away, but it feels like most of the code generators are not compatible yet. Or is it still recommended to go with v2 of the spec?

@derberg
Copy link
Member

derberg commented May 7, 2024

v3 release done, and coincidence is that it also support asyncapi v3
https://github.com/asyncapi/nodejs-template/releases/tag/v3.0.0

anyway, if there are any issues, feel free to report them

@derberg derberg closed this as completed May 7, 2024
@meteatamel
Copy link

Is v3 supported in nodejs-template? I get this error when I try:

 asyncapi generate fromTemplate email-service-3.0.yaml @asyncapi/nodejs-template -o email-service-3.0 -p server=test

┌  AsyncAPI Generator
Error: @asyncapi/nodejs-template template does not support AsyncAPI v3 documents, please checkout https://github.com/asyncapi/nodejs-template/issues/215

@derberg
Copy link
Member

derberg commented May 8, 2024

@meteatamel thanks! opened PR to CLI -> asyncapi/cli#1412

@derberg
Copy link
Member

derberg commented May 8, 2024

@meteatamel the latest AsyncAPI CLI release fixes the problem

@meteatamel
Copy link

Thanks @derberg, I tested and the code generation for Node.js works now with 3. 0

Copy link
Member

derberg commented May 9, 2024

Great!!! Thanks for confirmation!

fyi @kaushik-rishi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants