feat: add flag moveAllToComponents

asyncapi · Apr 4, 2024 · 4a7340a · 4a7340a
1 parent 8225cdd
commit 4a7340a
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 39 deletions.
diff --git a/examples/index.js b/examples/index.js
@@ -3,31 +3,22 @@ const { Optimizer } = require('../lib/Optimizer')
 
 // read input.yaml file synconously and store it as an string
 const input = require('fs').readFileSync('./examples/input.yaml', 'utf8')
-const optimizer = new Optimizer(input
-  , {
-  output: 'YAML',
-  rules: {
-    reuseComponents: true,
-    removeComponents: true,
-    moveAllToComponents: true,
-    moveDuplicatesToComponents: false,
-    schemas: false,
-  },
-}
-)
+const optimizer = new Optimizer(input)
 optimizer.getReport().then((report) => {
   console.log(report)
   const optimizedDocument = optimizer.getOptimizedDocument(
-  //   {
-  //   output: 'YAML',
-  //   rules: {
-  //     reuseComponents: true,
-  //     removeComponents: true,
-  //     moveAllToComponents: true,
-  //     moveDuplicatesToComponents: false,
-  //     schemas: false,
-  //   },
-  // }
+    {
+    output: 'YAML',
+    rules: {
+      reuseComponents: true,
+      removeComponents: true,
+      moveAllToComponents: true,
+      moveDuplicatesToComponents: false,
+    },
+    disableOptimizationFor: {
+      schema: true,
+    },
+  }
   )
   //store optimizedDocument as to output.yaml
   require('fs').writeFileSync('./examples/output.yaml', optimizedDocument)

diff --git a/src/ComponentProvider.ts b/src/ComponentProvider.ts
@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable security/detect-object-injection */
 import type { AsyncAPIDocumentInterface } from '@asyncapi/parser'
-import { OptimizableComponentGroup, OptimizableComponent, Options } from 'index.d'
+import { OptimizableComponentGroup, OptimizableComponent } from 'index.d'
 
 import { JSONPath } from 'jsonpath-plus'
 import _ from 'lodash'
@@ -54,7 +54,6 @@ export const parseComponentsFromPath = (
 
 export const getOptimizableComponents = (
   asyncAPIDocument: AsyncAPIDocumentInterface,
-  options?: Options
 ): OptimizableComponentGroup[] => {
   const optimizeableComponents: OptimizableComponentGroup[] = []
   const getAllComponents = (type: string) => {
@@ -84,14 +83,6 @@ export const getOptimizableComponents = (
     operationBindings: getAllComponents('operationBindings'),
     messageBindings: getAllComponents('messageBindings'),
   }
-  // In the case of `if (!options?.rules?.schemas)`, if `schemas` property is
-  // simply absent in the `options` object, the program's behavior will not turn
-  // to default `schemas: true`, but the absence of `schemas` will be considered
-  // `schemas: false`, due to `undefined` being considered `false` in JS. Thus,
-  // explicit check is performed.
-  if (options?.rules?.schemas === false) {
-    delete optimizableComponents.schemas
-  }
   for (const [type, components] of Object.entries(optimizableComponents)) {
     if (components.length === 0) continue
     optimizeableComponents.push({

diff --git a/src/Optimizer.ts b/src/Optimizer.ts
@@ -45,17 +45,16 @@ export class Optimizer {
   /**
    * @param {any} YAMLorJSON - YAML or JSON document that you want to optimize. You can pass Object, YAML or JSON version of your AsyncAPI document here.
    */
-  constructor(private YAMLorJSON: any, private options?: Options) {
+  constructor(private YAMLorJSON: any) {
     this.outputObject = toJS(this.YAMLorJSON)
     this.reporters = [
       removeComponents,
       reuseComponents,
       moveAllToComponents,
       moveDuplicatesToComponents,
     ]
-    this.options = options
   }
-  
+
   /**
    * @returns {Report} an object containing all of the optimizations that the library can do.
    *
@@ -68,14 +67,15 @@ export class Optimizer {
       console.error(parsedDocument.diagnostics)
       throw new Error('Parsing failed.')
     }
-    this.components = getOptimizableComponents(parsedDocument.document, this.options)
+    this.components = getOptimizableComponents(parsedDocument.document)
     const rawReports = this.reporters.map((reporter) => reporter(this.components))
     const reportsWithParents = rawReports.map((report) => ({
       type: report.type,
       elements: report.elements.filter((reportElement) =>
         hasParent(reportElement, this.outputObject)
       ),
     }))
+
     const filteredReports = filterReportElements(reportsWithParents)
     const sortedReports = filteredReports.map((report) => sortReportElements(report))
     this.reports = sortedReports
@@ -112,17 +112,24 @@ export class Optimizer {
         removeComponents: true,
         moveAllToComponents: true,
         moveDuplicatesToComponents: false, // there is no need to move duplicates if `moveAllToComponents` is `true`
-        schemas: true,
       },
       output: Output.YAML,
+      disableOptimizationFor: {
+        schema: false,
+      },
     }
-    options = merge(defaultOptions, this.options)
+    options = merge(defaultOptions, options)
     if (!this.reports) {
       throw new Error(
         'No report has been generated. please first generate a report by calling getReport method.'
       )
     }
     for (const report of this.reports) {
+      if (options.disableOptimizationFor?.schema === true) {
+        report.elements = report.elements.filter(
+          (element) => !element.target?.includes('.schemas.')
+        )
+      }
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       if (options.rules[report.type] === true) {

diff --git a/src/index.d.ts b/src/index.d.ts
@@ -35,11 +35,15 @@ interface Rules {
   removeComponents?: boolean
   moveAllToComponents?: boolean
   moveDuplicatesToComponents?: boolean
-  schemas?: boolean
+}
+
+export interface DisableOptimizationFor {
+  schema?: boolean
 }
 export interface Options {
   rules?: Rules
   output?: Output
+  disableOptimizationFor?: DisableOptimizationFor // non-approved type
 }
 
 export interface IOptimizer {