Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing approach for new spec versions #630

Closed
derberg opened this issue Sep 29, 2022 · 1 comment
Closed

Improve testing approach for new spec versions #630

derberg opened this issue Sep 29, 2022 · 1 comment
Labels
enhancement New feature or request stale

Comments

@derberg
Copy link
Member

derberg commented Sep 29, 2022

Reason/Context

At the moment, with every new release, we just add model tests + adjust generic tests (so we for example update generic tests to test 2.5 instead of 2.4 - not test in addition, but just test latest). Example #627

I think it is not the best approach. I feel that we should preserve some dedicated acceptance tests per version. Unit test but not a test that checks just a model, but actually parses entire AsyncAPI document, because it depends on @asyncapi/spec for example, where some breaking changes can be introduced.

Description

so what I suggest is a dedicated test per release, with dedicated sample spec, that showcases new features
In such release tests we parse entire example, and also test model functions for a given new feature.

@derberg derberg added the enhancement New feature or request label Sep 29, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 28, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant