Extract RAML and OpenAPI schema parsers to their own package #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaslagoni
requested changes
Mar 10, 2020
derberg
requested changes
Mar 10, 2020
There was a problem hiding this comment.
I ❤️ it
Just few things form my side.
In parser-js readme we should link to this plugin https://github.com/asyncapi/raml-dt-schema-parser/
This was referenced Mar 11, 2020
|
@fmvilas oh man, you already did OpenAPI plugin extraction. Well done! |
derberg
approved these changes
Mar 11, 2020
fmvilas
changed the title
|
@jonaslagoni do you think it's fine now? |
jonaslagoni
pushed a commit
to jonaslagoni/parser-js
that referenced
this pull request
Mar 19, 2020
…i#44) * Extract RAML parser to its own package * Remove RAML tests * Extract OpenAPI too * Add RAML and OpenAPI links to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes the bundle size of the parser much bigger. Next one could be the OpenAPI parser too.
The new package is here: https://www.github.com/asyncapi/raml-dt-schema-parser/
fixes #48