Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @asyncapi/specs to 4.2.0 version #730

Closed
wants to merge 4 commits into from

Conversation

asyncapi-bot
Copy link
Contributor

No description provided.

@jonaslagoni
Copy link
Member

jonaslagoni commented Mar 15, 2023

We do explicit validation of payloads, but now they are starting to be validated by our JSON Schema files, so we can start to phase them out. Thats why the tests fails because it expects our own validators to throw the error, now the core validation step.

@derberg
Copy link
Member

derberg commented Mar 15, 2023

@jonaslagoni but if we change the error type that we throw, it is a breaking change

@jonaslagoni
Copy link
Member

jonaslagoni commented Mar 15, 2023

Yea was going to ask that next 😆

Now sure which approach to take to update the dependency.

@derberg
Copy link
Member

derberg commented Mar 15, 2023

well, parser needs new major, of course we can just resign from bumping to latest specs package in master, and do bump only in 2.0 release candidate

IMHO 2.0-only is best approach. Especially that it is already integrated in some tools I think.

@fmvilas @magicmatatjahu @smoya share your thoughts please

@derberg
Copy link
Member

derberg commented Mar 27, 2023

@fmvilas @magicmatatjahu @smoya share your thoughts please

@smoya
Copy link
Member

smoya commented Mar 27, 2023

@fmvilas @magicmatatjahu @smoya share your thoughts please

Merging this in master should be considered a breaking change: some valid payloads will become invalid.
I suggest we skip this update for Parser-JS v1.x in favour of targeting v2 (next-major branch). Basically, +1 to @derberg suggestion.

Additionally, to create a new PR freezing@asyncapi/specs package for 1.x so no more @asyncapi-bot updates happen.

EDIT: Issue created #736

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target next-major branch

@fmvilas
Copy link
Member

fmvilas commented Mar 27, 2023

Yeah, I think it’s a breaking change too.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Apr 4, 2023

@smoya we're closing this one, right? you freezed the version?

@smoya
Copy link
Member

smoya commented Apr 4, 2023

@smoya we're closing this one, right? you freezed the version?

Yup, can be closed now. For the reference #737

@derberg derberg closed this Apr 4, 2023
@derberg derberg deleted the bot/bump-@asyncapi/specs-4.2.0 branch April 26, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants