Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: v3 request reply support #745

Merged
merged 3 commits into from
Apr 24, 2023
Merged

chore: v3 request reply support #745

merged 3 commits into from
Apr 24, 2023

Conversation

GreenRover
Copy link
Contributor

@GreenRover GreenRover commented Apr 3, 2023 •
edited
Loading

Description

Update v3 models:

Related issue(s)
See also #732

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@GreenRover
Copy link
Contributor Author

Now the pr #708 gots merged. I rebased my pr and only add parts where i not agree with #708
@magicmatatjahu Please review

@GreenRover GreenRover changed the title v3 request reply support chore: v3 request reply support Apr 13, 2023
@GreenRover
Copy link
Contributor Author

Ping @magicmatatjahu

magicmatatjahu
magicmatatjahu requested changes Apr 18, 2023
View reviewed changes
test/models/v3/operation.spec.ts Outdated Show resolved Hide resolved
src/models/v3/operation.ts Outdated Show resolved Hide resolved
src/models/operation.ts Outdated Show resolved Hide resolved
@GreenRover
Copy link
Contributor Author

GreenRover commented Apr 20, 2023 •
edited
Loading

@magicmatatjahu please re review

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit b59983c into asyncapi:next-major-spec Apr 24, 2023
2 checks passed
@jonaslagoni jonaslagoni mentioned this pull request Apr 26, 2023
Closed
@jonaslagoni jonaslagoni mentioned this pull request Jun 7, 2023
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GreenRover @magicmatatjahu @asyncapi-bot