Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterating between operations, channels and messages #948

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

jonaslagoni
Copy link
Sponsor Member

Description
Once before I implemented this functionality incorrectly. this PR fixes that operations, channels, and messages could not be iterated between each other. On top of that, the functionality did not work when references were local files, this has also been fixed.

Related issue(s)
Raised on slack: https://asyncapi.slack.com/archives/CQVJXFNQL/p1707760039073239

Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

src/parse.ts Show resolved Hide resolved
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@jonaslagoni
Copy link
Sponsor Member Author

/rtm

@jonaslagoni
Copy link
Sponsor Member Author

@smoya did you approve 🤔

@smoya
Copy link
Member

smoya commented Feb 16, 2024

/rtm

@smoya smoya merged commit 41ddb9d into asyncapi:master Feb 16, 2024
10 checks passed
@smoya smoya deleted the fix_traits_not_working_with_ref branch February 16, 2024 16:44
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants