Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unit, fmt, build on ci #211

Merged
merged 14 commits into from
Jul 8, 2024
Merged

Conversation

yurvon-screamo
Copy link
Collaborator

@yurvon-screamo yurvon-screamo commented May 20, 2024

Description

Auto run build, unit test, fmt chek on pull request and push to main branch (fmt has been success after merge editorconfig #210)

Related issue(s)

#209

@yurvon-screamo yurvon-screamo linked an issue May 20, 2024 that may be closed by this pull request
2 tasks
@yurvon-screamo yurvon-screamo changed the title 209 feature check fmt on ci Check unit, fmt, build on ci May 20, 2024
@yurvon-screamo yurvon-screamo added this to the code style milestone May 20, 2024
@smoerijf
Copy link
Contributor

smoerijf commented Jul 7, 2024

Is there anything blocking the PR? (as this PR is essential for the defined roadmap milestones and to progress the project...)

@yurvon-screamo
Copy link
Collaborator Author

Is there anything blocking the PR? (as this PR is essential for the defined roadmap milestones and to progress the project...)

Wait @VisualBean and merge)

For the first time, I think this ci is enough for us

@VisualBean
Copy link
Collaborator

Is there anything blocking the PR? (as this PR is essential for the defined roadmap milestones and to progress the project...)

Wait @VisualBean and merge)

For the first time, I think this ci is enough for us

Thanks for tagging me 😅 been incredibly busy.
Looks good 👍 ive approved

@yurvon-screamo yurvon-screamo merged commit 6a3441d into main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Check fmt + test on CI
3 participants