Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move tags and externalDocs objects from root to the info object #244

Merged
merged 4 commits into from
Feb 6, 2023
Merged

feat: move tags and externalDocs objects from root to the info object #244

merged 4 commits into from
Feb 6, 2023

Conversation

magicmatatjahu
Copy link
Member

Description

Move Tags and ExternalDocs objects from root to the Info object - changes in spec asyncapi/spec#794

Related issue(s)
Part of asyncapi/spec#794

@magicmatatjahu magicmatatjahu mentioned this pull request Jul 26, 2022
Merged
fmvilas
fmvilas approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni mentioned this pull request Sep 28, 2022
Closed
@magicmatatjahu magicmatatjahu mentioned this pull request Oct 4, 2022
Closed
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 24, 2022
@magicmatatjahu
Copy link
Member Author

@derberg @fmvilas We can merge that :) Please also remove stale label.

@github-actions github-actions bot removed the stale label Feb 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 2a8ea92 into asyncapi:next-major-spec Feb 6, 2023
@magicmatatjahu magicmatatjahu deleted the feat/move-tags-external-docs-to-info branch February 6, 2023 11:14
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magicmatatjahu @asyncapi-bot @char0n @fmvilas