feat: add host and pathname fields in server object

[magicmatatjahu]

Description

Add host and pathname fields in server object.

Related issue(s)
Part of asyncapi/spec#888

[char0n]

LGTM. Nice job!

[magicmatatjahu]

@fmvilas @char0n Thanks! However I think that we should add some regex (or format) to validate the proper host and pathname, not treat fields as normal strings. WDYT? The problem is that I will (probably) learn Regex again 😆

[char0n]

@magicmatatjahu we theoretically can, here are the representation in pseudo context-free grammar for host and pathname.

host:

host:
      ‘[‘ ipv6-address ‘]’
      ipv4-or-reg-name

ipv6-address:
      (any input-character except ‘/’ and ‘]’)+
ipv4-or-reg-name:
      (any input-character except ‘/’, ‘:’, ‘?’ and ‘#’)+

pathname

As far as I understand this is https://url.spec.whatwg.org/#dom-url-pathname without search part

absolute-path:
      ‘/’
      (path-separator segment)+

path-separator:
      ‘/’
    
segment:
      (any input-character except ‘/’, ‘?’ and ‘#’)*

It should be possible to convert these context-free grammars into regular expressions.

[fmvilas]

@fmvilas @char0n Thanks! However I think that we should add some regex (or format) to validate the proper host and pathname, not treat fields as normal strings. WDYT? The problem is that I will (probably) learn Regex again 😆

I would create another issue for this. This is the kind of task that can quickly become a rabbithole.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[magicmatatjahu]

@fmvilas Ok, I created issue #336 I'm merging that PR, or do you want to add something?

[magicmatatjahu]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 5.0.0-next-major-spec.11 🎉

The release is available on:

• npm package (@next-major-spec dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[asyncapi-bot]

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

• npm package (@next-major-spec dist-tag)
• GitHub release

Your semantic-release bot 📦🚀