-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make traits an array of traits or refs #339
Conversation
@AceTheCreator You should fix that in all |
@AceTheCreator you can actually close #81 as well with these changes 🙂 |
definitions/2.6.0/message.json
Outdated
@@ -134,29 +128,10 @@ | |||
"items": { | |||
"oneOf": [ | |||
{ | |||
"$ref": "http://asyncapi.com/definitions/2.6.0/Reference.json" | |||
"$ref": "http://asyncapi.com/definitions/2.5.0/Reference.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong version
Any additional thoughts on this PR @jonaslagoni @derberg @magicmatatjahu |
definitions/2.6.0/message.json
Outdated
"additionalItems": true | ||
} | ||
] | ||
"$ref": "http://asyncapi.com/definitions/2.5.0/messageTrait.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did you make changes to schemas
, did you do some manual stuff there?
Yes, I did. In the traits object |
You should generate schemas by following https://github.com/asyncapi/spec-json-schemas#schema-bundling |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
/rtm |
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-next-major-spec.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Currently, the traits can be defined as an array of arrays of traits and refs, but in the spec, it says it should be an array of traits or refs.
cc @jonaslagoni @derberg @fmvilas
resolves #273 and #81