Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make traits an array of traits or refs #339

Merged
merged 7 commits into from
Mar 9, 2023
Merged

fix: make traits an array of traits or refs #339

merged 7 commits into from
Mar 9, 2023

Conversation

AceTheCreator
Copy link
Member

@AceTheCreator AceTheCreator commented Feb 15, 2023 •
edited by derberg
Loading

Currently, the traits can be defined as an array of arrays of traits and refs, but in the spec, it says it should be an array of traits or refs.

cc @jonaslagoni @derberg @fmvilas

resolves #273 and #81

@magicmatatjahu
Copy link
Member

@AceTheCreator You should fix that in all 2.x.x versions.

@jonaslagoni
Copy link
Member

@AceTheCreator you can actually close #81 as well with these changes 🙂

@jonaslagoni jonaslagoni mentioned this pull request Feb 20, 2023
Closed
jonaslagoni added a commit to jonaslagoni/spec-json-schemas that referenced this pull request Feb 20, 2023
@jonaslagoni
ensure consistency and fixed asyncapi#339
16ce1cc
derberg
derberg reviewed Feb 22, 2023
View reviewed changes
definitions/2.6.0/message.json Outdated
@@ -134,29 +128,10 @@
"items": {
"oneOf": [
{
"$ref": "http://asyncapi.com/definitions/2.6.0/Reference.json"
"$ref": "http://asyncapi.com/definitions/2.5.0/Reference.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong version

@AceTheCreator
Copy link
Member Author

AceTheCreator commented Mar 1, 2023 •
edited
Loading

Any additional thoughts on this PR @jonaslagoni @derberg @magicmatatjahu

derberg
derberg reviewed Mar 9, 2023
View reviewed changes
definitions/2.6.0/message.json Outdated
"additionalItems": true
}
]
"$ref": "http://asyncapi.com/definitions/2.5.0/messageTrait.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong version

derberg
derberg reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you make changes to schemas, did you do some manual stuff there?

@AceTheCreator
Copy link
Member Author

how did you make changes to schemas, did you do some manual stuff there?

Yes, I did. In the traits object

@smoya
Copy link
Member

smoya commented Mar 9, 2023

how did you make changes to schemas, did you do some manual stuff there?

Yes, I did. In the traits object

You should generate schemas by following https://github.com/asyncapi/spec-json-schemas#schema-bundling

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AceTheCreator
Copy link
Member Author

Updated this PR cc @derberg @smoya

derberg
derberg approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

smoya
smoya approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@AceTheCreator
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 8de66a8 into asyncapi:master Mar 9, 2023
@AceTheCreator AceTheCreator deleted the fix-traits-object branch March 9, 2023 13:00
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AceTheCreator AceTheCreator mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traits can be defined as double arrays
6 participants
@AceTheCreator @magicmatatjahu @jonaslagoni @smoya @asyncapi-bot @derberg