Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: release version 5.0.0 #389

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 27, 2023

#386 did work

I finally learned why. There release config was in a wrong location so semantic-release applied defaults, which is for conventional commits it used angular way that do not respect feat! or fix! but requires explicit BREAKING CHANGE:

now this release config is globally fixed everywhere and in the root of the repo

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your perseverance.

@derberg
Copy link
Member Author

derberg commented Apr 27, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 7817199 into asyncapi:master Apr 27, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants