Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new simplified parameter #415

Merged

Conversation

jonaslagoni
Copy link
Sponsor Member

Description
This PR adapts the schemas to correctly validate the new simplified parameter object: https://www.asyncapi.com/docs/reference/specification/v3.0.0-next-major-spec.12#parameterObject

Related issue(s)
Fixes #413
Related to asyncapi/spec#583

@jonaslagoni jonaslagoni changed the base branch from master to next-major-spec July 25, 2023 10:29
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented Jul 25, 2023

@jonaslagoni you should submit the bundled versions of the 3.0.0 schema, right?

@jonaslagoni
Copy link
Sponsor Member Author

@smoya it's part of the release process, better not to commit it 🙂

@jonaslagoni
Copy link
Sponsor Member Author

Thanks for the quick review folks 😄

@jonaslagoni
Copy link
Sponsor Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 1aebba2 into asyncapi:next-major-spec Jul 25, 2023
23 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jul 25, 2023

@jonaslagoni jonaslagoni deleted the new_simplified_parameter branch July 25, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new simplified channel parameters JSON Schema required changes
4 participants