Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script and CI job to validate spec examples #957

Open
jonaslagoni opened this issue Aug 2, 2023 · 20 comments
Open

Add a script and CI job to validate spec examples #957

jonaslagoni opened this issue Aug 2, 2023 · 20 comments
Assignees
Labels
bounty AsyncAPI Bounty keep-open Prevents stale bot from closing this issue or PR

Comments

@jonaslagoni
Copy link
Sponsor Member

This feature request was discussed here: #947 (comment)

We need to make sure all the examples are complete and valid according to our spec. This should of course be checked for each PR that change the examples.

@smoya
Copy link
Member

smoya commented Sep 17, 2023

We should include the examples embeded into the spec itself, not only the files under the examples dir. Related to this: #971

In order to do that, those examples would need to be fully working AsyncAPI files instead of partials. Otherwise validation won't work. If we want to avoid having full AsyncAPI documents as embedded examples, we could maybe do some trick in CI and add all the minimum required fields to each example before validating.

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 16, 2024
@smoya smoya added keep-open Prevents stale bot from closing this issue or PR and removed stale labels Feb 19, 2024
@smoya
Copy link
Member

smoya commented Feb 19, 2024

I consider this as a potential issue for next Bounty program. Not sure if there is a way of keeping track potential issues for next rounds somewhere. Perhaps labels 🤔

cc @aeworxet

@aeworxet
Copy link

I consider this as a potential issue for next Bounty program.

Sure, anyone from CODEOWNERS of this repository can submit it.

Not sure if there is a way of keeping track potential issues for next rounds somewhere. Perhaps labels 🤔

Up until now, it was simply something the maintainer just remembered.
If there is a huge flow of potential Bounty Issues in the future, I will of course introduce a way to mark those for coming calendar rounds with something like bounty/potential.
Adding GH labels to issues by a user is troublesome because, in order to SIMPLY add a label, a user needs to have full write permission to the repository, which, of course, is not likable by anyone. So I am eyeing one of the existing GH Actions bots, but no ready decision has been made yet.

@derberg
Copy link
Member

derberg commented Feb 22, 2024

yeah, would be good to have a kinda "reminder" like bounty/candidate or something

@smoya
Copy link
Member

smoya commented Feb 22, 2024

The work could be split in two phases:

  1. Validation of all AsyncAPI documents under /examples dir in the Spec repo. https://github.com/asyncapi/spec/tree/master/examples. I believe we could use For the record, I believe we could use https://github.com/asyncapi/github-action-for-cli
  2. Validation of all examples embedded in the spec itself. Such as the following https://github.com/asyncapi/spec/blob/master/spec/asyncapi.md#multi-format-schema-object-examples

However, I believe both should be part of the same bounty program issue.

@AnimeshKumar923
Copy link
Contributor

AnimeshKumar923 commented Mar 6, 2024

Hello there 👋 @jonaslagoni @smoya

If it's fine with you, I would be glad to work on this issue under the Bounty Program, 2024-Q2 as this is a potential issue for the Program.

Thanks! 👍


cc: @aeworxet

@aeworxet
Copy link

aeworxet commented Mar 7, 2024

@AnimeshKumar923
Submitted.

@AnimeshKumar923
Copy link
Contributor

Thank you! @aeworxet @smoya

@derberg
Copy link
Member

derberg commented Mar 7, 2024

ah yes, let's have it on the bounty, definitely 🍺 thanks @AnimeshKumar923 for reminder

@Shurtu-gal
Copy link

Hope I am not late 😔. Would love to help out in any way possible 😉.

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Mar 18, 2024
@aeworxet
Copy link

Bounty Issue's service comment

Text labels: bounty/2024-Q2, bounty/medium, bounty/coding
First assignment to third-party contributors: 2024-03-22 00:00:00 UTC+12:00
End Of Life: 2024-08-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

@smoya
Copy link
Member

smoya commented Mar 19, 2024

Considering @Shurtu-gal is already assigned to two Bounty issues already (having reached the limit), it is automatically discarded from this one in favour of @AnimeshKumar923, who additionally applied earlier, and also worked on similar issues in the past.

So @AnimeshKumar923 this is all yours.

@AnimeshKumar923
Copy link
Contributor

Considering @Shurtu-gal is already assigned to two Bounty issues already (having reached the limit), it is automatically discarded from this one in favour of @AnimeshKumar923, who additionally applied earlier, and also worked on similar issues in the past.

So @AnimeshKumar923 this is all yours.

Thank you for this opportunity! 🙏 @smoya
Grateful to be participating again and work with you... 🙇


cc: @aeworxet assignment has been made. Please update the timeline for this issue. Thanks 👍

@aeworxet
Copy link

Bounty Issue's Timeline

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-03-19 2024-04-01 2024-05-10 2024-04-12 2024-04-26 2024-05-10
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.

@aeworxet
Copy link

#1046 (comment)

@aeworxet
Copy link

Upon request of the Bounty Program Participant (@AnimeshKumar923), all remaining target dates of the Bounty Issue's Timeline are extended by six calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-03-19 2024-04-01 2024-06-21 2024-04-12 2024-06-07 2024-06-21
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@AnimeshKumar923
Copy link
Contributor

From May 19th to May 28th, I had prolonged break-downs of telecommunications in my area (which included internet shutdown). This situation is subject to Article 3(f) of the ICC Force Majeure and Hardship Clauses. Hence, I request an additional extension by two weeks to the one I already have.

cc: @aeworxet @smoya

@AnimeshKumar923
Copy link
Contributor

Progress Update

@aeworxet
Copy link

aeworxet commented Jun 1, 2024

Upon request of the Bounty Program Participant (@AnimeshKumar923), all remaining target dates of the Bounty Issue's Timeline are extended by eight calendar weeks.

Bounty Issue's Timeline Extended

Complexity Level Assignment date (by GitHub) Start date (by BP rules) End date (by BP rules) Draft PR submission Final PR submission Final PR merge
Medium 2024-03-19 2024-04-01 2024-07-05 2024-04-12 2024-06-21 2024-07-05
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty keep-open Prevents stale bot from closing this issue or PR
Projects
Status: In Progress
Development

No branches or pull requests

7 participants