Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use reference to the json-schema draft-07 in monaco editor #159

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

magicmatatjahu
Copy link
Member

Description

Use reference to the json-schema draft-07 in the Monaco editor.

Related issue(s)
See more asyncapi/spec-json-schemas#119

@netlify
Copy link

netlify bot commented Nov 2, 2021

✔️ Deploy Preview for modest-rosalind-098b67 ready!

🔨 Explore the source changes: fe01c99

🔍 Inspect the deploy log: https://app.netlify.com/sites/modest-rosalind-098b67/deploys/6181367d9161ef00089692ea

😎 Browse the preview: https://deploy-preview-159--modest-rosalind-098b67.netlify.app/

@@ -0,0 +1,173 @@
/* eslint-disable sonarjs/no-duplicate-string */
export default {
$schema: 'http://json-schema.org/draft-07/schema#',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, I suggested this asyncapi/spec-json-schemas#120 for the future.

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🌔

@smoya
Copy link
Member

smoya commented Nov 2, 2021

https://github.com/asyncapi/spec-json-schemas/releases/tag/v2.10.1 is out now. Just in case you wanna include it in this PR @magicmatatjahu

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu magicmatatjahu merged commit 515107b into asyncapi:master Nov 2, 2021
@magicmatatjahu magicmatatjahu deleted the fix-schemas branch November 2, 2021 13:22
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants