fix: update parser-js to v2 #615
Conversation
smoya
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
smoya
force-pushed
the
chore/updateParsers
branch
3 times, most recently
from
4de0acb
to
a4e1aef
Compare
src/services/parser.service.ts
Outdated
| await this.subscribeToSettings(); | ||
| await this.parseSavedDocuments(); |
There was a problem hiding this comment.
It won't wait because subscription is a procedure, not function :) So I don't think so that this is needed.
There was a problem hiding this comment.
SonarCloud complains about this being missing.
src/index.tsx
Outdated
| @@ -32,7 +32,7 @@ function configureMonacoEnvironment() { | |||
| }; | |||
| } | |||
|
|
|||
| async function bootstrap() { | |||
| (async () => { | |||
There was a problem hiding this comment.
Why did you change bootstrap function to something like that?
There was a problem hiding this comment.
SonarCloud complains (marks as a bug) with something like this iirc: "Promises must be awaited, end with a call to .catch, or end with a call to .then with a rejection handler"
There was a problem hiding this comment.
As we see, Sonarcloud was written by Java people 😆 Ok.
|
Something doesn't work. When I remove |
smoya
force-pushed
the
chore/updateParsers
branch
3 times, most recently
from
ab1ce46
to
768b01c
Compare
Being honest, I don't understand why changing the following lines back to what it was previously fixes the issue: 768b01c |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
smoya
force-pushed
the
chore/updateParsers
branch
from
0b2fa93
to
2f45428
Compare
smoya
force-pushed
the
chore/updateParsers
branch
from
2f45428
to
04ec1f9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @asyncapi/studio-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Replaces #572
Description
This PR updates @asyncapi/parser to v2 and uses the recently released custom schema parsers.
Note: this PR does not change Studio to start using the new Parser-API but keeps using the old wrapper
const oldDocument = convertToOldAPI(document);.Related issue(s)
asyncapi/parser-js#585