-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch model renders #53
feat: switch model renders #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! Only two comments :)
I'm curious why you're generating the models on a hook instead of using these functions in a |
|
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
🤦 Thanks for pointing me to this, Maciej! |
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@fmvilas I have no preferences, this is just how I did it with QuickType and to not mix different changes into one PR I will keep it like this. But it is a good point. I am however unsure how I can even achieve this without the following issue to be addressed first: asyncapi/generator-react-sdk#10 Then I would have to iterate messages myself and generate models per payload 🤔 |
Short answer yes you could do that. The problem is there are multiple ways of doing it depending on your use-case. If you used However without this issue I don't think I would be able to incorporate it into a file schema the way I want it to😄 |
I don't completely follow but don't want to make you lose time. Let's discuss this next Wednesday on the retrospective 👍 |
# Conflicts: # package-lock.json
… into feature/integrate_new_model_gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You probably wait for asyncapi/generator-react-sdk#10, is it true?
@magicmatatjahu no I will solve the conflicts in a sec. #54 will be for waiting for that issue you linked :) |
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @fmvilas review |
I've put up a pull request to add @fmvilas! 🎉 |
Description
This PR switches from QuickType model generation to our own implementation.
Related issue(s)
Solves asyncapi/shape-up-process#50