Error: TypeError: The "path" argument must be of type string. Received undefined #146

leigh-johnson · 2022-11-27T18:06:17Z

Describe the bug

👋 Hey there, thanks for all the hard work on this extension! I'm seeing the following error when I attempt to open a preview using command+shift+p.

2022-11-27 09:56:40.704 [error] TypeError: The "path" argument must be of type string. Received undefined
	at new NodeError (node:internal/errors:371:5)
	at validateString (node:internal/validators:120:11)
	at Object.dirname (node:path:1276:5)
	at a (/home/leigh/.vscode/extensions/asyncapi.asyncapi-preview-0.4.0/dist/extension.js:1:179602)
	at /home/leigh/.vscode/extensions/asyncapi.asyncapi-preview-0.4.0/dist/extension.js:1:181584
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async s._executeContributedCommand (/snap/code/113/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:92:111367) asyncapi.preview {"value":"asyncapi.asyncapi-preview","_lower":"asyncapi.asyncapi-preview"}

VS Code version:

Version: 1.73.1
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T03:54:53.913Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.15.0-53-generic snap
Sandboxed: No

How to Reproduce

Open an async API schema
Press control+shift+p or command+shift-p to open commands
Select Preview AsyncAPI command
I'm getting prompted to open an AsyncAPI file, even though I already have one open in VS Code. I verified my schema is valid via https://studio.asyncapi.com/
After selecting the Async API schema again (even though it's already open in my editor), I'm seeing the following error:

In VSCode's Output under Log (Extension Host) I see the following error:

2022-11-27 10:05:00.129 [error] TypeError: The "path" argument must be of type string. Received undefined
	at new NodeError (node:internal/errors:371:5)
	at validateString (node:internal/validators:120:11)
	at Object.dirname (node:path:1276:5)
	at a (/home/leigh/.vscode/extensions/asyncapi.asyncapi-preview-0.4.0/dist/extension.js:1:179602)
	at /home/leigh/.vscode/extensions/asyncapi.asyncapi-preview-0.4.0/dist/extension.js:1:181584
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async s._executeContributedCommand (/snap/code/113/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:92:111367) asyncapi.preview {"value":"asyncapi.asyncapi-preview","_lower":"asyncapi.asyncapi-preview"}

Maybe the extension is unable to find an executable named asyncapi? Unsure how to proceed or how this should be sandboxed. Thanks for looking into this! 🙇‍♀️

Schema: https://github.com/bitsy-ai/printnanny-asyncapi-schema/blob/main/2.5.0/printnanny-os.yml

Expected behavior

File preview opens in a new panel.

The text was updated successfully, but these errors were encountered:

github-actions · 2022-11-27T18:06:30Z

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

derberg · 2022-12-01T11:59:53Z

Works well with:

Version: 1.72.2
Commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075
Date: 2022-10-12T22:16:30.254Z (1 mo ago)
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 20.6.0
Sandboxed: No

now I made an upgrade

Version: 1.73.1
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T02:08:38.961Z (3 wks ago)
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 20.6.0
Sandboxed: No

The only different that I can see between our setup os OS. I'm on Mac.

other extensions that support preview work for you? like markdown previewer for example?

and still works, both command+shift+p and also menu

leigh-johnson · 2022-12-01T22:17:17Z

Yep, markdown and HTML previews work for me. Is there a way to increase the verbosity of what's logged under Log (Extension Host)?

derberg · 2022-12-05T11:10:39Z

There is for now just one console.log -> https://github.com/asyncapi/vs-asyncapi-preview/blob/master/src/PreviewWebPanel.ts#L8 but of course more can be added.

You do not see these under Log (Extension Host) but Help -> Toogle Developer Tools and there in the Console

philCryoport · 2022-12-13T01:15:17Z

I'm running into this same issue with plugin version 0.4.0:

foo.yaml

asyncapi: 2.5.0 id: urn:com.asyncapi.examples.user info: title: User signed-up event version: 0.1.1 channels: user/signedup: publish: message: payload: type: object properties: fullName: type: string email: type: string format: email age: type: integer minimum: 18

The Preview AsyncAPI option appears in the ellipsis (...) menu and works just fine.

However, if I:

cmd-shift-p
choose Preview AsyncAPI
select the file

...the Dev Tools Console shows:

[Extension Host] Setting context for asyncapi.isAsyncAPI true <directory structure removed>/foo.yaml
workbench.desktop.main.js:89
[Extension Host] Opening asyncapi file undefined workbench.desktop.main.js:89

Help?

ivangsa · 2022-12-13T08:23:27Z

I @philCryoport

I don't have a Mac to test this, but does the editor menu (on the top right corner of you file editor) work for you?

…syncapi#146

ivangsa · 2022-12-13T09:39:15Z

Hi @leigh-johnson @philCryoport

can you try (unziping and) installing this package and test if it fixes this issue

(to install de vsix, from inside vscode -> right click on the file and select Install Extension VSIX)

asyncapi-preview-0.4.0.vsix.zip

philCryoport · 2022-12-13T20:55:12Z

Hi @leigh-johnson @philCryoport

can you try (unziping and) installing this package and test if it fixes this issue

(to install de vsix, from inside vscode -> right click on the file and select Install Extension VSIX)

asyncapi-preview-0.4.0.vsix.zip

Hi @ivangsa I'm a little wary of installing a binary file from an untrusted source (please don't take offense, this is a standard precaution). I'll try building your PR and then installing it from there

philCryoport · 2022-12-13T22:36:02Z

Hi @leigh-johnson @philCryoport
can you try (unziping and) installing this package and test if it fixes this issue
(to install de vsix, from inside vscode -> right click on the file and select Install Extension VSIX)
asyncapi-preview-0.4.0.vsix.zip

Hi @ivangsa I'm a little wary of installing a binary file from an untrusted source (please don't take offense, this is a standard precaution). I'll try building your PR and then installing it from there

@leigh-johnson I pulled your PR and compiled it. No error dialog message...however here's what DevTools showed when I:

Opened the YAML file
Chose Preview AsyncAPI from the ellipsis dropdown in the upper right

[Extension Host] Setting context for asyncapi.isAsyncAPI true /<directory>/foo.yaml
workbench.desktop.main.js:89 [Extension Host] Opening asyncapi file /<directory>/foo.yaml
DevTools failed to load source map: Could not load content for https://ticino.blob.core.windows.net/sourcemaps/cb188d662af4ff5d43505b572b49905a1f0153ad/core/vs/workbench/contrib/webview/browser/pre/service-worker.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

...in comparison, when I do Command Palette and just pick the YAML file from the Open File dialog, then I only get:

workbench.desktop.main.js:89 [Extension Host] Opening asyncapi file /<directory>/foo.yaml

ivangsa · 2022-12-14T08:37:44Z

I don't see the error locally and I don't know this url https://ticino.blob.core.windows.net/

@philCryoport I suspect this error is unrelated to the asyncapi preview...

philCryoport · 2022-12-16T01:50:24Z

I don't see the error locally and I don't know this url https://ticino.blob.core.windows.net/

@philCryoport I suspect this error is unrelated to the asyncapi preview...

Anyhoo -- the fix you put into the code seemed to work. When you get a moment would you please publish a new release?

Thanks!

)

asyncapi-bot · 2022-12-19T14:38:16Z

🎉 This issue has been resolved in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fourlincoln10 · 2023-01-12T02:18:30Z

The marketplace still has version 0.4.0. Will you push 0.4.1 to the marketplace please?

derberg · 2023-01-12T11:54:02Z

This is odd. GitHub action says that it was published:

Publishing 'asyncapi.asyncapi-preview v0.4.1'...
  Extension URL (might take a few minutes): https://marketplace.visualstudio.com/items?itemName=asyncapi.asyncapi-preview
  Published asyncapi.asyncapi-preview v0.4.1.

And in the same run it was successfully published to https://open-vsx.org/extension/asyncapi/asyncapi-preview 🤷‍♂️

And... https://marketplace.visualstudio.com/items?itemName=asyncapi.asyncapi-preview says it was actually updated on 19.12 - which means the day of 0.4.1 release

We need to investigate what this inconsistency happened there

Related CI runs https://github.com/asyncapi/vs-asyncapi-preview/actions/runs/3732414616/jobs/6331836655

derberg · 2023-01-12T11:58:14Z

What I get when I check it in Marketplace as admin

derberg · 2023-01-12T12:36:33Z

I honestly do not know why as admin I see latest is 0.4.1 but in marketplace it is 0.4.0

@ivangsa have you even seen stuff like that?

ivangsa · 2023-01-12T14:52:39Z

in marketplace version 0.4.0 shows publish date 19/12/22 which is odd

I'm guessing that this may be an error in the marketplace..

I downloaded the file and it looks like actually the 0.4.0 version

ivangsa · 2023-01-12T15:36:42Z

maybe we can redeploy now, and investigate this later... it looks to me like issue on the marketplace...

derberg · 2023-01-12T17:49:57Z

Ok, lets do it. PR opened #152

derberg · 2023-01-13T09:02:05Z

@ivangsa you were right, it was some temporary issue on marketplace side. New release was successful.

@fourlincoln10 0.4.2 is out in the wild

fourlincoln10 · 2023-01-13T22:05:56Z

Thanks! I see it in the marketplace now. Much appreciated.Sent from my iPhoneOn Jan 13, 2023, at 1:02 AM, Lukasz Gornicki ***@***.***> wrote: @ivangsa you were right, it was some temporary issue on marketplace side. New release was successful. @fourlincoln10 0.4.2 is out in the wild —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

leigh-johnson added the bug Something isn't working label Nov 27, 2022

ivangsa added a commit to ivangsa/vs-asyncapi-preview that referenced this issue Dec 13, 2022

fix: The "path" argument must be of type string. Received undefined a…

8d0f532

…syncapi#146

ivangsa mentioned this issue Dec 13, 2022

fix: return one single file when prompting for AsyncAPI files #146 #150

Merged

asyncapi-bot closed this as completed in #150 Dec 19, 2022

asyncapi-bot pushed a commit that referenced this issue Dec 19, 2022

fix: return one single file when prompting for AsyncAPI files #146 (#150

6feb87f

)

asyncapi-bot added the released label Dec 19, 2022

derberg mentioned this issue Jan 12, 2023

fix: update marketplace related badges #152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: TypeError: The "path" argument must be of type string. Received undefined #146

Error: TypeError: The "path" argument must be of type string. Received undefined #146

leigh-johnson commented Nov 27, 2022

github-actions bot commented Nov 27, 2022

derberg commented Dec 1, 2022

leigh-johnson commented Dec 1, 2022

derberg commented Dec 5, 2022

philCryoport commented Dec 13, 2022

ivangsa commented Dec 13, 2022

ivangsa commented Dec 13, 2022

philCryoport commented Dec 13, 2022 •

edited

philCryoport commented Dec 13, 2022 •

edited

ivangsa commented Dec 14, 2022

philCryoport commented Dec 16, 2022

asyncapi-bot commented Dec 19, 2022

fourlincoln10 commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 12, 2023

ivangsa commented Jan 12, 2023

ivangsa commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 13, 2023

fourlincoln10 commented Jan 13, 2023 via email

Error: TypeError: The "path" argument must be of type string. Received undefined #146

Error: TypeError: The "path" argument must be of type string. Received undefined #146

Comments

leigh-johnson commented Nov 27, 2022

Describe the bug

How to Reproduce

Expected behavior

github-actions bot commented Nov 27, 2022

derberg commented Dec 1, 2022

leigh-johnson commented Dec 1, 2022

derberg commented Dec 5, 2022

philCryoport commented Dec 13, 2022

ivangsa commented Dec 13, 2022

ivangsa commented Dec 13, 2022

philCryoport commented Dec 13, 2022 • edited

philCryoport commented Dec 13, 2022 • edited

ivangsa commented Dec 14, 2022

philCryoport commented Dec 16, 2022

asyncapi-bot commented Dec 19, 2022

fourlincoln10 commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 12, 2023

ivangsa commented Jan 12, 2023

ivangsa commented Jan 12, 2023

derberg commented Jan 12, 2023

derberg commented Jan 13, 2023

fourlincoln10 commented Jan 13, 2023 via email

philCryoport commented Dec 13, 2022 •

edited

philCryoport commented Dec 13, 2022 •

edited