Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return one single file when prompting for AsyncAPI files #146 #150

Merged
merged 1 commit into from Dec 19, 2022

Conversation

ivangsa
Copy link
Collaborator

@ivangsa ivangsa commented Dec 13, 2022

  • vscode.window.showOpenDialog returns an array even when canSelectMany is set to false

  • sets context to show "AsyncAPI Preview" button on Editor Title Bar when saving new files (that may not been 'asyncapi' files before saving)

closes #146

@ivangsa ivangsa changed the title fix: The "path" argument must be of type string. Received undefined #146 fix: return one single file when propmting for AsyncAPI files #146 Dec 13, 2022
@ivangsa ivangsa changed the title fix: return one single file when propmting for AsyncAPI files #146 fix: return one single file when prompting for AsyncAPI files #146 Dec 13, 2022
@ivangsa
Copy link
Collaborator Author

ivangsa commented Dec 16, 2022

hi @derberg this is confirmed to work, can you merge it..

@derberg
Copy link
Member

derberg commented Dec 19, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 6feb87f into asyncapi:master Dec 19, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: TypeError: The "path" argument must be of type string. Received undefined
3 participants