Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve scroll position on preview reload #206

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

nikhilkalburgi
Copy link
Contributor

Signed-off-by: nikhilkalburgi nikhilkalburgi19@gmail.com

Fixes #168

Description

  • Used message passing feature of webview to preserve the position
  • load event and settimeout is used as we need to wait until the asynapistandalone completes
  • the panel retains the position of webview and passes that when the openasynapi is called again
11.02.2024_18.42.31_REC.mp4

Signed-off-by: nikhilkalburgi <nikhilkalburgi19@gmail.com>

Fixes #168
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ivangsa
Copy link
Collaborator

ivangsa commented Feb 12, 2024

Awesome!! Thanks for this @nikhilkalburgi !!

@ivangsa
Copy link
Collaborator

ivangsa commented Feb 12, 2024

rtm

@ivangsa ivangsa closed this Feb 12, 2024
@ivangsa ivangsa reopened this Feb 12, 2024
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivangsa
Copy link
Collaborator

ivangsa commented Feb 12, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 11d6d21 into asyncapi:master Feb 12, 2024
24 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll position not preserved on reload in preview page
3 participants