Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore 0.9 branch #98

Merged
merged 10 commits into from
Apr 22, 2023
Merged

restore 0.9 branch #98

merged 10 commits into from
Apr 22, 2023

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Apr 22, 2023

No description provided.

Motivation:
To ensure compatibility and consistency across the R2DBC ecosystem, it is important to use the latest upstream dependencies. Therefore, I updated the Reactor BOM version to 2022.0.0 since r2dbc-pool already use it.

Modifications:
Changed the Reactor BOM version to 2022.0.0 in the project's POM file.

Result:
The project now uses the latest Reactor BOM version, which ensures compatibility and consistency across the R2DBC ecosystem.
Motivation:
Reactor-extra is defined within the dependencies block but not in use

Modifications:
Remove reactor-extra from dependencies block

Results:
Cleanup
Motivation:
To keep the developer list up-to-date.

Modifications:
Remove inactive developers

Result:
POM file is up-to-date.
Motivation:
Using organization in POM reduces effort for maintaining it.

Modifications:
Put organization info and remove developers section.

Results:
Less effort to maintain pom.xml.
Motivation:
Meaning less to include style.xml in project root. since we have no
check-style in CI/CD phase.

Modifications:
Remove style.xml

Results:
Clean up
Motivation:
varchar binary, the union of JSON and char binary columns are not being
accurately mapped to the appropriate MySqlType.

Modification:
Use collationId(charset id) to identify mysql type.

Result:
Enhanced MySqlType Identification.
Resolves #91
Motivation:
EmitterProcessor is deprecated

Modifications:
Used Sink to replace deprecated EmitterProcessor

Results:
Up-to-date with Reactor
Motivation:
0.9 branch's github config is out-of-date

Modification:
Synced with trunk

Result:
up-to-date
Motivation:
-Werror compiler args are set with no reason. it makes compilation fail.

Modification:
Removed the arg.

Result:
Successful compilation.
@jchrys jchrys merged commit 65517f9 into 0.9 Apr 22, 2023
7 checks passed
@jchrys jchrys deleted the 0.9-fu branch April 22, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant