Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

costmap_cspace: fixes memory access error on global map boundary. #49

Merged
merged 23 commits into from
Jul 28, 2017
Merged

costmap_cspace: fixes memory access error on global map boundary. #49

merged 23 commits into from
Jul 28, 2017

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Jul 27, 2017

fixes #46
waiting #47

at-wat added 22 commits July 25, 2017 12:26
@at-wat
Refactor costmap_cspace package.
a42d3e9
@at-wat
Fix coding styles.
8b3eb76
@at-wat
Merge branch 'master' into cc-refactor
36c037d
@at-wat
Split costmap calculation into a class.
969f3ce
@at-wat
Fixing Costmap3DOF class structure and adding tests.
0aaf4e2
@at-wat
Revert test. (will be in next PR)
e9e0e1a
@at-wat
Add funcs to get state and add some asserts.
6ed8f2d
@at-wat
Wrap 3-D array access and add asserts.
ddff60f
@at-wat
Fix variable names and getCostRef access privilege.
fbdc47f
@at-wat
Remove ros::Time::now and use stamp of input map.
cfc6e97
@at-wat
Add a lot of consts.
6c2829c
@at-wat
Add index range check and assert.
130122b
@at-wat
Fix unsigned variable with negative value in grid address calculation.
1d45988
@at-wat
Fix node to follow variable name change (fbdc47).
bdc0086
@at-wat
Fix cost array accessor target (ddff60).
9a0ab94
@at-wat
Add some more asserts.
112edfb
@at-wat
Fix invalid use of Vec.
80963e8
@at-wat
Revert "Fix unsigned variable with negative value in grid address cal…
7cb766b 
…culation."

This reverts commit 1d45988.
@at-wat
Revert "Fix invalid use of Vec."
592a601 
This reverts commit 80963e8.
@at-wat
Fix unsigned variable with negative value in grid address calculation.
4db74bc
@at-wat
Fix invalid use of Vec.
d0e7ca7
@at-wat
Fix cost array accessor target (ddff60).
bf4685a
@at-wat at-wat added the waiting label Jul 27, 2017
@at-wat at-wat self-assigned this Jul 27, 2017
@at-wat at-wat mentioned this pull request Jul 28, 2017
Merged
@at-wat at-wat removed the waiting label Jul 28, 2017
@at-wat at-wat mentioned this pull request Jul 28, 2017
Closed
@at-wat
Copy link
Owner Author

at-wat commented Jul 28, 2017

confirmed that the bug has been fixed in simulation.
#48 will add test to detect the bug.

@at-wat at-wat merged commit e64d606 into master Jul 28, 2017
@at-wat at-wat deleted the cc-fix-memory-access-violations branch July 28, 2017 02:33
at-wat added a commit that referenced this pull request Jul 28, 2017
@at-wat
costmap_cspace: adds unit tests. (#48)
543607a 
Now, the bug fixed by #49 can be detected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

costmap_cspace: Memory access error on global map boundary.
1 participant
@at-wat