Add safety_limiter_msgs package #16

DaikiMaekawa · 2019-09-09T04:42:14Z

No description provided.

at-wat · 2019-09-09T04:45:38Z

[#39] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#39] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

DaikiMaekawa · 2019-09-09T04:46:55Z

@at-wat PTAL

at-wat · 2019-09-09T08:40:07Z

[#40] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#40] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

at-wat

How about adding some values which are already sent to diagnostics topic?
https://github.com/at-wat/neonavigation/blob/970c3fab11c07aec76714809a1b3953a1ea40d4c/safety_limiter/src/safety_limiter.cpp#L671-L695

at-wat · 2019-09-09T09:14:24Z

[#41] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#41] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

DaikiMaekawa · 2019-09-09T09:27:18Z

@at-wat Added. https://github.com/at-wat/neonavigation_msgs/pull/16/files#diff-890558fa1cd6f908ee9876a9aecbdc8fR9-R11

at-wat · 2019-09-11T03:26:51Z

@DaikiMaekawa basically looks good to me. Let's merge it after implementing a publisher in safety_limiter.

at-wat · 2019-09-11T07:37:22Z

[#42] FAILED on kinetic

catkin_make failed

[#42] FAILED on melodic

catkin_make failed

at-wat · 2019-09-11T07:42:14Z

[#43] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#43] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

at-wat · 2019-09-11T08:34:03Z

safety_limiter_msgs/msg/SafetyLimiterStatus.msg

+float64 limit_ratio
+bool is_cloud_available
+bool has_watchdog_timed_out
+time stuck_started_since


meaning of zero value (not being stuck) should be described as a comment.

at-wat · 2019-09-11T09:11:27Z

[#44] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#44] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

at-wat

A dependency from the meta-package should be added.

neonavigation_msgs/neonavigation_msgs/package.xml

Lines 13 to 16 in 17cd056

    
           <exec_depend>planner_cspace_msgs</exec_depend> 
        
           <exec_depend>costmap_cspace_msgs</exec_depend> 
        
           <exec_depend>map_organizer_msgs</exec_depend> 
        
           <exec_depend>trajectory_tracker_msgs</exec_depend>

at-wat · 2019-09-17T02:25:20Z

safety_limiter_msgs/package.xml

+<?xml version="1.0"?>
+<package format="2">
+  <name>safety_limiter_msgs</name>
+  <version>0.0.0</version>


should be 0.3.1

at-wat · 2019-09-17T04:24:05Z

[#45] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#45] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

at-wat · 2019-09-17T04:49:37Z

@DaikiMaekawa dependency from neonavigation/package.xml should be added. #16 (review)

at-wat · 2019-09-17T05:57:42Z

[#46] PASSED on kinetic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

[#46] PASSED on melodic

All tests passed

build/test_results/trajectory_tracker_msgs/gtest-test_convert.xml: 2 tests
build/test_results/trajectory_tracker_msgs/roslint-trajectory_tracker_msgs.xml: 1 tests
Summary: 3 tests, 0 errors, 0 failures, 0 skipped

at-wat

LGTM
I'll update PR title and merge this soon.

at-wat · 2019-09-17T06:16:45Z

merging

DaikiMaekawa added 3 commits September 9, 2019 13:33

safety_limiter_msgs package created

6411bea

ignore the backup files

df051cf

add package dependencies

5bf726b

DaikiMaekawa requested a review from at-wat September 9, 2019 04:46

stuck status is added

003de26

at-wat reviewed Sep 9, 2019

View reviewed changes

useful data added in the msg

b42b723

at-wat self-requested a review September 9, 2019 11:00

stuck_started_since defined

ef93acf

fix typo

2832a6b

at-wat reviewed Sep 11, 2019

View reviewed changes

the status removed

06b5367

at-wat reviewed Sep 17, 2019

View reviewed changes

DaikiMaekawa added 2 commits September 17, 2019 13:19

describe the non-zero meaning

8eb083d

address review comment

402755a

DaikiMaekawa requested a review from at-wat September 17, 2019 04:20

safety_limiter_msgs specified in the meta package

3e48363

at-wat approved these changes Sep 17, 2019

View reviewed changes

at-wat changed the title ~~safety_limiter_msgs package~~ Add safety_limiter_msgs package Sep 17, 2019

at-wat merged commit 095701f into master Sep 17, 2019

at-wat deleted the safety-limiter-msgs branch September 17, 2019 06:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add safety_limiter_msgs package #16

Add safety_limiter_msgs package #16

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 9, 2019 •

edited

Loading

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 9, 2019 •

edited

Loading

at-wat left a comment

at-wat commented Sep 9, 2019 •

edited

Loading

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 11, 2019

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat Sep 11, 2019

DaikiMaekawa Sep 17, 2019

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat left a comment

at-wat Sep 17, 2019

DaikiMaekawa Sep 17, 2019

at-wat commented Sep 17, 2019 •

edited

Loading

at-wat commented Sep 17, 2019

at-wat commented Sep 17, 2019 •

edited

Loading

at-wat left a comment

at-wat commented Sep 17, 2019

	<exec_depend>planner_cspace_msgs</exec_depend>
	<exec_depend>costmap_cspace_msgs</exec_depend>
	<exec_depend>map_organizer_msgs</exec_depend>
	<exec_depend>trajectory_tracker_msgs</exec_depend>

Add safety_limiter_msgs package #16

Add safety_limiter_msgs package #16

Conversation

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 9, 2019 • edited Loading

[#39] PASSED on kinetic

[#39] PASSED on melodic

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 9, 2019 • edited Loading

[#40] PASSED on kinetic

[#40] PASSED on melodic

at-wat left a comment

Choose a reason for hiding this comment

at-wat commented Sep 9, 2019 • edited Loading

[#41] PASSED on kinetic

[#41] PASSED on melodic

DaikiMaekawa commented Sep 9, 2019

at-wat commented Sep 11, 2019

at-wat commented Sep 11, 2019 • edited Loading

[#42] FAILED on kinetic

[#42] FAILED on melodic

at-wat commented Sep 11, 2019 • edited Loading

[#43] PASSED on melodic

[#43] PASSED on kinetic

at-wat Sep 11, 2019

Choose a reason for hiding this comment

DaikiMaekawa Sep 17, 2019

Choose a reason for hiding this comment

at-wat commented Sep 11, 2019 • edited Loading

[#44] PASSED on kinetic

[#44] PASSED on melodic

at-wat left a comment

Choose a reason for hiding this comment

at-wat Sep 17, 2019

Choose a reason for hiding this comment

DaikiMaekawa Sep 17, 2019

Choose a reason for hiding this comment

at-wat commented Sep 17, 2019 • edited Loading

[#45] PASSED on kinetic

[#45] PASSED on melodic

at-wat commented Sep 17, 2019

at-wat commented Sep 17, 2019 • edited Loading

[#46] PASSED on kinetic

[#46] PASSED on melodic

at-wat left a comment

Choose a reason for hiding this comment

at-wat commented Sep 17, 2019

at-wat commented Sep 9, 2019 •

edited

Loading

at-wat commented Sep 9, 2019 •

edited

Loading

at-wat commented Sep 9, 2019 •

edited

Loading

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat commented Sep 11, 2019 •

edited

Loading

at-wat commented Sep 17, 2019 •

edited

Loading

at-wat commented Sep 17, 2019 •

edited

Loading