fix compatibility issue with webpack 4 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.option.context` has been deprecated since webpack 3, it's been replaced by `this.rootContext` in webpack 4.
|
Please look into merging this :) |
|
also interested on this. |
at0g
requested changes
Mar 2, 2018
index.js
Outdated
| @@ -73,7 +73,7 @@ module.exports = function (source) { | |||
| hasRun = true; | |||
| } | |||
|
|
|||
| var name = slash(path.relative(root || this.options.context, this.resourcePath)); | |||
| var name = slash(path.relative(root || this.rootContext, this.resourcePath)); | |||
There was a problem hiding this comment.
Thanks, can keep this.options.context for backwards compatability please.
slash(path.relative(root || this.rootContext || this.options.context, this.resourcePath));
|
@at0g done! |
|
merge this maybe? |
at0g
approved these changes
Mar 4, 2018
|
@at0g can we also get a npm release please? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.option.contexthas been deprecated since webpack 3, it's beenreplaced by
this.rootContextin webpack 4.I haven't tested everything, this is just a really quick fix I did to make my webpack 4 compile.
I also don't know if this fix is backwards compatible.
however, this was the only instance of
this.options.contextin the code, so I doubt it will break anything.See #61