Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility issue with webpack 4 #62

Merged
merged 2 commits into from
Mar 4, 2018
Merged

fix compatibility issue with webpack 4 #62

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790cc07
fix compatibility issue with webpack 4
S0yKaf Feb 28, 2018
05f9b2a
add backwards compatibility
S0yKaf Mar 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = function (source) {
hasRun = true;
}

var name = slash(path.relative(root || this.options.context, this.resourcePath));
var name = slash(path.relative(root || this.rootContext, this.resourcePath));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can keep this.options.context for backwards compatability please.

slash(path.relative(root || this.rootContext || this.options.context, this.resourcePath));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 smart


var nunjucksCompiledStr = nunjucks.precompileString(source, {
env: env,
Expand Down