This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
eventhub capture reading #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmasterplan
force-pushed
the
feature/eh-capture
branch
from
bef8c4c
to
4dbb739
Compare
LauJohansson
reviewed
Apr 6, 2022
LauJohansson
reviewed
Apr 6, 2022
LauJohansson
reviewed
Apr 6, 2022
LauJohansson
reviewed
Apr 6, 2022
mrmasterplan
force-pushed
the
feature/eh-capture
branch
from
4dbb739
to
41d664d
Compare
mrmasterplan
force-pushed
the
feature/eh-capture
branch
from
8cd8fea
to
3946c15
Compare
|
@JeppeBlixen Do you want to review before we merge? We are missing some good documentation for the class. I hope you can get started with the example in the unittest. |
JeppeBlixen
reviewed
Apr 11, 2022
There was a problem hiding this comment.
It looks good to me, some nice features around the partitioning. This could also be used for other time partitioned file sources, for example json. Would it make sense to split this? One part with generalized logic about the partitioning, and another more related to the eventhub with the validation and table creation.
|
@JeppeBlixen That's great input for the next PR. For now I want to complete this and get on with my vacation. We can talk again after easter. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.